Include node details when the node is new#101
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Jul 1, 2025
Merged
Include node details when the node is new#101TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
tnull
approved these changes
Jul 1, 2025
andrei-21
approved these changes
Jul 1, 2025
Contributor
andrei-21
left a comment
andrei-21
left a comment
There was a problem hiding this comment.
Indeed the v2 snapshots on mainnet have announcement infos for nodes. Also it works in my regtest setup.
Thank you.
TheBlueMatt
force-pushed
the
main
branch
7 times, most recently
from
aba1602 to
07f6692
Compare
Contributor
Author
|
Fixed broken test and updated the test logic to test a bit more. Will land this once it passes given no further runtime changes happened. |
In cases where we only receive node details for the first time after the last-seen timestamp, we were mistakenly not including the node info at all in the snapshot. This was the most egregious for initial syncs, where we'd include no node info at all. Luckily the fix is simple, just include a full node info sync in such cases. Fixes lightningdevkit#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where we only receive node details for the first time after the last-seen timestamp, we were mistakenly not including the node info at all in the snapshot. This was the most egregious for initial syncs, where we'd include no node info at all.
Luckily the fix is simple, just include a full node info sync in such cases.
Fixes #100