Merged
Conversation
When building a slice with `slice::from_raw_parts`, we're required to pass in a non-NULL pointer even if the length is 0. While we did this in most cases, we weren't always careful about it. Here we fix the issue by using a simple wrapper which passes a dummy pointer instead.
Because we're always reading from a fixed-length buffer anyway, we can always support it with our existing code.
There's no need for this assertion, the code should be the same between named fields and tuple fields.
Both new `rust-bitcoin` types as well as support for `i32` and cloning `Option_NoneZ`.
We'd always intended to do this, but never got around to it, so might as well.
Sadly its not currently possible to map `lightning-liquidity` to bindings as it requires additional (`Clone`) bounds on various trait objects passed in to the top-level manager constructor. Because we don't anticipate bindings users using it immediately, we simply drop it here.
TheBlueMatt
commented
Dec 11, 2025
Collaborator
Author
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
The non-auto-generated bits of this are quite straightforward so just gonna land. The macOS crash I have no idea about but we've seen crap like that before that didn't impact release builds (and valgrind and addrsan don't complain on Linux, so....)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on lightningdevkit/rust-lightning#4264