Clarify about the length of a r field in invoice
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
reviewed
May 7, 2021
joemphilips
force-pushed
the
clarify_r_field_in_invoice
branch
2 times, most recently
from
c033771
to
73c7654
Compare
* In current spec, route-hint can't express more than 3 hops. * From a reader's point of view, what can not be done in a spec is often more important than what can be done. Thus clarify about its limitation.
joemphilips
force-pushed
the
clarify_r_field_in_invoice
branch
from
73c7654
to
79a1d03
Compare
rustyrussell
reviewed
Jun 7, 2021
| * `fee_base_msat` (32 bits, big-endian) | ||
| * `fee_proportional_millionths` (32 bits, big-endian) | ||
| * `cltv_expiry_delta` (16 bits, big-endian) | ||
| * Be aware that `data_length` can express `2^10` (=1024 bits) as the longest, and a single hop will be 51 bytes (= 408 bits). So currently there is no way to specify a hint with more than two hops. |
There was a problem hiding this comment.
Weirdly, data_length is expressed in 5-bit amounts, so there is 5120 bits. You can fit 12 hops in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.