Bump: runtime 1.1.30 #544
Bump: runtime 1.1.30 #544
Conversation
github-actions
bot
added
javascript-sdk
kalix-runtime
|
Not sure what was going on, couldn't push to the original auto-bump PR, so created my own branch, but then that commit ended up in the original bump PR anyway somehow. 😕 |
| @@ -175,7 +175,7 @@ export class IntegrationTestkit { | |||
| 'VERSION_CHECK_ON_STARTUP', | |||
| process.env.VERSION_CHECK_ON_STARTUP || 'true', | |||
| ) | |||
| .withWaitStrategy(Wait.forLogMessage('Starting Kalix ')) | |||
| .withWaitStrategy(Wait.forLogMessage('Connecting to ')) | |||
There was a problem hiding this comment.
Seems the order of discovery and logs changed somewhat in the runtime, causing a deadlock because waiting for the Starting Kalix log output, but that was only logged once discovery completes, and discovery would not complete until the test container proxy port is injected a few lines down from here.
There was a problem hiding this comment.
that's odd, the line is still there...
There was a problem hiding this comment.
I mean in the runtime code
There was a problem hiding this comment.
Yeah it logs it but I think it must have been logging it earlier before, and now does it only after discovery completes, but the JS SDK blocks that when in test mode, because it needs to know the test container port before it can continue.
|
Meh, all green but circle did not report back properly. |
|
The same again, all steps of the CI workflow green over at Circle but not reported back here. |
Replaces #543