Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update env var for runtime version #530

Merged
merged 4 commits into from
Jan 3, 2024
Merged

ci: update env var for runtime version #530

merged 4 commits into from
Jan 3, 2024

Conversation

efgpinto
Copy link
Member

@efgpinto efgpinto requested a review from ennru December 21, 2023 10:43
@github-actions github-actions bot added the kalix-runtime Runtime and SDKs sub-team label Dec 21, 2023
ennru
ennru reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even here generally prefer the ${...} syntax.
LGTM.

.vscode/settings.json Outdated
@@ -0,0 +1 @@
{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was not intended.

bin/update-proxy-versions.sh
@@ -1,32 +1,32 @@
#!/usr/bin/env bash

# USAGE:
# > PROXY_VERSION=1.0.31 ./update-proxy-versions.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the script, as well? (Preferably less broken than I did in the JVM SDK.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets do that. https://github.com/lightbend/kalix-runtime/pull/2271

bin/update-proxy-versions.sh Outdated Show resolved Hide resolved
@efgpinto
Copy link
Member Author

We are getting 429 Too Many Requests for https://hub.docker.com/_/node .. I will retry later.

@efgpinto efgpinto merged commit d7512a7 into main Jan 3, 2024
13 checks passed
@efgpinto efgpinto deleted the update-env-var branch January 3, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efgpinto @ennru