Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to "Kalix Runtime" #525

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Switch to "Kalix Runtime" #525

merged 3 commits into from
Dec 13, 2023

Conversation

ennru
Copy link
Member

@ennru ennru commented Dec 13, 2023

@ennru ennru marked this pull request as draft December 13, 2023 10:36
@github-actions github-actions bot added Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk labels Dec 13, 2023
@ennru ennru marked this pull request as ready for review December 13, 2023 10:56
@ennru ennru mentioned this pull request Dec 13, 2023
Closed
efgpinto
efgpinto approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question.

sdk/bin/prepare.sh
# runtime project source directory
echo "Using snapshot of proxy and sdk protocols from '$RUNTIME_SNAPSHOT_DIRECTORY'"
cp -rf $RUNTIME_SNAPSHOT_DIRECTORY/protocols/proxy/src/main/protobuf/* ./proto/
cp -rf $RUNTIME_SNAPSHOT_DIRECTORY/protocols/sdk/src/main/protobuf/* ./proto/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we set this ENV VAR RUNTIME_SNAPSHOT_DIRECTORY ? I could not find it.. jsut making sure we update that piece as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this done manually for local development when you want to develop against an unreleased Runtime version with sources on your machine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, makes sense 👍

@ennru ennru merged commit 85ad090 into main Dec 13, 2023
13 checks passed
@ennru ennru deleted the ennru-runtime-image-2 branch December 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efgpinto efgpinto efgpinto approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @efgpinto