bump: update node base image in Dockerfiles to 18-bookworm-slim #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
javascript-sdk
kalix-runtime
aludwiko
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the dockerfiles to node 18 was missed in #459. Drop the minor version to keep maintaining this simple.
Also bump the debian version from debian 10 (buster) to current stable debian 12 (bookworm). This is required, as the CI images were updated to ubuntu 22.04 in #434, and the published codegen native images now require a newer glibc. See #406 for when this was downgraded again for this reason. We could also switch the codegen native image builds for linux to static binaries to avoid this issue on dynamically linking libc.