feat: generate just typescript #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecorredor
force-pushed
the
generate-ts
branch
from
2af9a24 to
e18d43c
Compare
|
Merging this PR will result in a major version bump. Created by lifeomic-probot (Enforce Semantic Commits) |
swain
approved these changes
Feb 12, 2024
jkdowdle
approved these changes
Feb 12, 2024
| module.exports.Client = Client; | ||
| `, | ||
| declaration: `/* eslint-disable */ | ||
| typescript: `/* eslint-disable */ |
There was a problem hiding this comment.
I think we do since eslint does also check typescript files. If we don't, it might be worth putting it as another change.
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INCLUDES BREAKING CHANGE
Motivations
In order to make integration in downstream consumers easier, we've migrated from generating separate code (
.js) and declaration (.d.ts) files to only generating a single TypeScript (.ts) file. The main reason for this is thattscdoes not include.d.tsfiles by default in its build process, which break consumers that have used this package before the build step, since they'll lose the generated.d.tsfile when their build process generates its own from the.jsfile that this package also generates.