fix: make prettier a production dependency #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
force-pushed
the
fix-prettier-dep
branch
from
d9049c9 to
34734b8
Compare
swain
requested review from
nicolls1,
aecorredor,
SchaeStewart,
jkdowdle and
epeters3
jkdowdle
approved these changes
Feb 9, 2024
|
🎉 This PR is included in version 5.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prettier is used in the CLI here: https://github.com/lifeomic/one-schema/blob/master/src/bin/cli.ts#L34
By not making this a production dependency, we force consumers to have
prettierinstalled, and we use their version instead. This creates a bug for any consumers usingprettierv3, which returns aPromisefromformat, instead of a synchronousstring.