Revert "feat: support variadic middleware for routes" #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
requested review from
nicolls1,
aecorredor,
jkdowdle,
epeters3 and
shawnzhu
This reverts commit 2ae7a3e.
swain
force-pushed
the
revert-variadic
branch
from
0cdb7d0 to
04db122
Compare
aecorredor
approved these changes
Nov 8, 2023
|
🎉 This PR is included in version 5.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rolls back the changes from #85.
Motivation
We discovered that #85 significantly degraded the behavior of auto-complete in route implementations. This is super lame and antithetical to the value of
one-schema. Since there has been minimal/no adoption of this new feature, going to roll it back as afix:for now, until we can find a way to release it without degrading auto-complete.