Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebasable Token #3

Merged
merged 206 commits into from
Oct 12, 2024
Merged

Rebasable Token #3

merged 206 commits into from
Oct 12, 2024

Conversation

kovalgek
Copy link

@kovalgek kovalgek commented Apr 16, 2024 •
edited
Loading

WHAT

Implement a new Rebasable token (stETH).

HOW

  • add a new token
  • change L1 and L2 bridges to support new token flows.
  • add token rate oracle for storing rate on L2
  • add token updater for emergency flow
    Detailed schemes and explanations can find here https://hackmd.io/@lido/ryKP1ssm6

It is a copy of lidofinance#58.

TODO:

  • OZ versions
  • DepositDataCodec. Asynchronous bridge update and fuzz decodeDepositData.
  • use safeIncreaseAllowance instead of approve
  • Deposit/Withdrawal zero tokens
  • PermitExtension - EIP-5267
  • Proxy - unified approach, update specs
  • ERC20RebasableBridged __disable_Initializers
  • ERC20RebasableBridged.unwrap() _getSharesByTokens - zero amount case
  • ERC20RebasableBridged add transferShares()/transferSharesFrom()
  • ERC20BridgedPermit. Init new storage?
  • ERC20RebasableBridged. _getTokensByShares e2e for decimal dimention
  • ERC20RebasableBridged. _getTokensByShares zero
  • check ErrorWrongOracleUpdateTime revert

@kovalgek
create new contract that represents stETH on L2
3256d9f
@kovalgek
add wrap/unwrap functions
e4b2cbd
@kovalgek
add shares to rebasable token
82038ea
@kovalgek
add unit tests
380caaa
@kovalgek
add deposit flow for new rebasable token
eab8718
@kovalgek
add withdraw flow for rebasable token on optimism
c3bc0db
@kovalgek
send rate in data and time during deposit flow
eb98d0b
@kovalgek
add possibility to depost 0 tokens
800e33f
@kovalgek
init structs
d9ac556
@kovalgek
add comments
ddb9ca3
@kovalgek
add gas test
a73bcf4
@kovalgek
update gas test
6d37edc
@kovalgek
fix tests
8098fe1
@kovalgek
add token rate oracle
3335339
@kovalgek
add tests for new token, renaming
86037dc
@kovalgek
simplify oracle, remove warnings
86788b2
@kovalgek
update unit tests for token rate oracle
ddffe1f
@kovalgek
fix integration tests for rebasable token
7c79d2d
@kovalgek
Merge branch 'main' into feature/add_stETH_token_to_optimism
6174943
@kovalgek
add test for push token rate method
f0b891a
@kovalgek
unused return values fix
e314bb1
@kovalgek
fix deployment scripts for new oracle and token
4b56ccf
@kovalgek
add hearbeat to oracle
3b82da7
@kovalgek
pr fixes from first rount review: apply unstructured storage in token…
171db5a 
…, rename consts, rename variables, fix comments
@kovalgek
PR fixes: fix comments, rename interface, abstract wst
76b4ff3
@kovalgek
use real implemnations of non rebasable token and oracle contracts in…
7abf60f 
… rebnasable token tests
@kovalgek
update unit tests for bridges
707da9b
@kovalgek
fix evetns + formating
1cb344a
@kovalgek
Merge branch 'main' into feature/add_stETH_token_to_optimism
f9463f0
@kovalgek
move token rate to the base contract
3fd1e94
arwer13 and others added 28 commits August 2, 2024 11:23
@arwer13
Merge pull request #24 from lidofinance/feature/add_crosschain_relayer
9b7c07b 
Add cross-chain relayer
@arwer13
Merge pull request #19 from lidofinance/check_balances
780c0af 
balance check script
@kovalgek
rename envs, add comments, imrpove deploy scripts
638b1af
@kovalgek
change gov executor in env example
821f49d
@kovalgek
Merge pull request #25 from lidofinance/feature/improve_deploy_scripts
c14070f 
rename envs, add comments, improve deploy scripts
@kovalgek
use deployer as admin when deploy token rate oracle, improve deploy logs
516ba26
@kovalgek
Merge pull request #26 from lidofinance/feature/improve_deploy_scripts2
60b10d7 
Improve deploy scripts
@kovalgek
add bytecode verificator with config
0810bb7
@arwer13
Merge pull request #27 from lidofinance/feature/bytecode_verificator
78516b6 
Add bytecode verificator with config
@kovalgek
fix scripts for fork upgrade rehersal
1e643c8
@kovalgek
fix rebasable token integration tests
2f9e8de
@kovalgek
new package lock
12b842a
@kovalgek
fix: Make storage-layout up to date
7b6e5ad
@tamtamchik
fix: ci runners node version
fdc79e5
@tamtamchik
Merge branch 'feature/rebasable_token' into feature/rebasable_token_ci
956e879
@tamtamchik
ci: add trigger on push and PR
a561beb
@tamtamchik
ci: use only PR, no need to check every push
440c7c0
@tamtamchik
chore: formatting
fe8478f
@tamtamchik
Merge pull request #34 from lidofinance/feature/rebasable_token_ci
bfd6840 
fix: ci runners node version
@kovalgek
update address for ci bytecode verification
2a8ef3e
@TheDZhon
Merge pull request #33 from lidofinance/update-storage-layout-feature…
71b5cf2 
…/rebasable_token

Update .storage-layout for feature/rebasable_token branch
@TheDZhon
Merge pull request #35 from lidofinance/feature/new_adresses_for_byte…
32dc66a 
…code_ci

Update address for CI bytecode verification
@kovalgek
use envs in on-fly deposits check script
a05c70a
@kovalgek
fix steth bridging integraion tests. use shares to check ballances
b5e3656
@kovalgek
add deposit/withdrawal wstETH test variants for different state of L1…
6a438cc 
… or L2
@kovalgek
use named parameters in factory method
3f94f2f
@kovalgek
add readme for tests
0fcd7ab
@kovalgek
Merge pull request #38 from lidofinance/feature/withdrawal_tests
a2ef375 
Add deposit/withdrawal wstETH test variants for different state of L1/L2
@TheDZhon TheDZhon merged commit 78936cc into main Oct 12, 2024
5 checks passed
@TheDZhon TheDZhon deleted the feature/rebasable_token branch October 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

@loga4 loga4 Awaiting requested review from loga4

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kovalgek @TheDZhon @arwer13 @loga4 @tamtamchik