chore: Sync SR1.5 branch with the latest develop #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the size of the third-phase report, it may be split into multiple transactions.
Distribute reward separately using the permissionless method in each staking module.
…-third-phase-fix Feat/multi transaction oracle third phase fix
Update contract version and reward distribution state.
Co-authored-by: avsetsin <[email protected]>
new parameter placed at the end of struct to preserve data order compatibility on read
Ackee L2: Potential revert on underflow. In the Staking Router, an unsafe update of the exited validators count could potentially cause the total exited validators count to exceed the total deposited validators count. This would break the pre-defined invariant: activeValidatorsCount = totalDepositedValidators - totalExitedValidators. This fix ensures the integrity of the active validators count by preventing such an underflow.
Ackee L3: The clearNodeOperatorPenalty returns always false
Ackee I2: Missing event on clearNodeOperatorPenalty
Ackee I3: Typo in node operator registry function name
# Conflicts: # lib/deploy.ts # scripts/scratch/deployed-testnet-defaults.json # scripts/scratch/steps/0030-deploy-template-and-app-bases.ts # scripts/scratch/steps/0090-deploy-non-aragon-contracts.ts # test/0.4.24/contracts/NodeOperatorsRegistry__Harness.sol # test/0.4.24/nor/nor.aux.test.ts # test/0.4.24/nor/nor.initialize.upgrade.test.ts # test/0.4.24/nor/nor.management.flow.test.ts # test/0.4.24/nor/nor.rewards.penalties.flow.test.ts # test/0.4.24/nor/nor.signing.keys.test.ts # test/0.8.9/contracts/StakingModule__Mock.sol # test/0.8.9/contracts/StakingRouter__MockForDepositSecurityModule.sol # test/0.8.9/contracts/StakingRouter__MockForSanityChecker.sol # test/0.8.9/contracts/oracle/OracleReportSanityCheckerMocks.sol # test/0.8.9/depositSecurityModule.test.ts # test/0.8.9/oracle/accountingOracle.submitReport.test.ts # test/0.8.9/oracle/accountingOracle.submitReportExtraData.test.ts # test/0.8.9/oracle/baseOracle.accessControl.test.ts # test/0.8.9/sanityChecker/oracleReportSanityChecker.misc.test.ts # test/0.8.9/sanityChecker/oracleReportSanityChecker.negative-rebase.test.ts # test/0.8.9/stakingRouter/stakingRouter.misc.test.ts # test/0.8.9/stakingRouter/stakingRouter.module-management.test.ts # test/0.8.9/stakingRouter/stakingRouter.module-sync.test.ts # test/0.8.9/stakingRouter/stakingRouter.rewards.test.ts # test/0.8.9/stakingRouter/stakingRouter.status-control.test.ts # test/0.8.9/stakingRouter/stakingRouter.versioned.test.ts # test/common/minFirstAllocationStrategy.t.sol # test/deploy/dao.ts
Sr 1.5 sync
…velop-sync # Conflicts: # test/0.8.9/oracle/hashConsensus.submitReport.test.ts
5 tasks
tamtamchik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make the update as smooth as possible 🫡
Restored CI actions, unit tests, and scratch deployment.
TODO:
/contracts/*/test_helpers/to/testPort of lidofinance/core#216