-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Lido v2 fix comments #779
base: develop
Are you sure you want to change the base?
Conversation
"ether" is not capitalized on ethereum.org, so we should not too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Like it
Left some suggestions.
Worth discussing the general approach regarding re-deployments here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is good though a bit of chores would be nice to have 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
It looks better
…-typo fix: exited validators count typo in IStakingModule interface
… from Math256.sol
Leaving this PR open as a reminder for the next upgrade but the repo is no longer maintained. LidoFinance protocol moved to core repository. |
Aggregate contract comment fixes related to v2 here