Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update LidoLocator with wstEth contract address #164

Closed
wants to merge 24 commits into from
Closed

feat: update LidoLocator with wstEth contract address #164

wants to merge 24 commits into from

Conversation

tamtamchik
Copy link
Member

Related issue lidofinance/lido-dao#849

@tamtamchik
chore: update contributing guide again
7693ed0
@tamtamchik
chore: 0.4.24 grooming
92880a6
@tamtamchik
chore: 0.4.24 grooming continues
b988d27
@tamtamchik
chore: 0.4.24 grooming continues more
c2864a1
@tamtamchik
chore: 0.4.24 grooming lido and nor tests
3531d28
@tamtamchik
chore: 0.4.24 grooming done
7169cad
@tamtamchik
chore: 0.6.12 grooming done
f58b34d
@tamtamchik
chore: 0.8.4 grooming done
f9dc2be
@tamtamchik
chore: cleanup some deploy params
cf52ab9
@tamtamchik
chore: 0.8.9 grooming contracts
97ba06d
@tamtamchik
chore: 0.8.9 grooming done
9b9b8ed
@tamtamchik
chore: grooming sol files and deploys
46a4f5b
@tamtamchik
fix: ci errors
d475cbe
@tamtamchik
ci: bump hh version
4b84f0f
@tamtamchik
chore: add auto-lint for test contracts
0d9df71
@tamtamchik
Merge pull request #159 from lidofinance/feat/mock-harness
81e68be 
chore: grooming code and separate mock / harness contracts
@tamtamchik
lint: run prettier
2fc9848
@tamtamchik
feat: add wstEth to LidoLocator
46993d5
@tamtamchik
fix: test and scratch deploy
f85bafb
@tamtamchik
fix: locator deployment for tests
c406de1
@tamtamchik
ci: try to invalidate cache
2778b98
@tamtamchik tamtamchik changed the base branch from develop to repovation August 26, 2024 14:55
@tamtamchik
ci: try to invalidate cache - reverted
c426a86 
This reverts commit 2778b98.
@tamtamchik
Merge branch 'repovation' into feat/locator-update
66dcdc5 
# Conflicts:
#	test/0.4.24/contracts/LidoLocator__MutableMock.sol
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   19       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                303       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      171       1  99.42%   723
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      171       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
TOTAL                                                           2852      96  96.63%

Diff against master

Filename                                                       Stmts    Miss  Cover
-----------------------------------------------------------  -------  ------  --------
contracts/0.8.9/LidoLocator.sol                                   +1       0  +100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      -54       0  +100.00%
TOTAL                                                            -53       0  -0.03%

Results for commit: d462d8a

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

@tamtamchik tamtamchik marked this pull request as ready for review August 26, 2024 15:51
@tamtamchik tamtamchik requested a review from a team as a code owner August 26, 2024 15:51
@tamtamchik tamtamchik changed the base branch from repovation to develop August 27, 2024 16:55
@tamtamchik tamtamchik requested a review from a team as a code owner August 27, 2024 16:55
@tamtamchik tamtamchik marked this pull request as draft August 27, 2024 16:55
@tamtamchik tamtamchik mentioned this pull request Aug 29, 2024
Merged
@tamtamchik tamtamchik added paused Work on this issue or pull request is temporarily halted. contracts Pull requests that add add or update contracts. labels Aug 30, 2024
@tamtamchik tamtamchik self-assigned this Sep 25, 2024
@tamtamchik tamtamchik mentioned this pull request Oct 11, 2024
Draft
@tamtamchik
Copy link
Member Author

Closed. Ported to lidofinance/lido-dao#863

@tamtamchik tamtamchik closed this Oct 11, 2024
@tamtamchik tamtamchik deleted the feat/locator-update branch October 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon Awaiting requested review from TheDZhon

Assignees

@tamtamchik tamtamchik

Labels
contracts Pull requests that add add or update contracts. paused Work on this issue or pull request is temporarily halted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tamtamchik