Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor permalog tweaks #16300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor permalog tweaks #16300

wants to merge 2 commits into from
+31 −17

Conversation

schlawg
Copy link
Collaborator

@schlawg schlawg commented Oct 31, 2024

  • escapeHtml will try to serialize if a non-string sneaks by tsc. will still fail if an object has cyclic refs or a BigInt
  • wrap log function in try/catch and serialize e.reason if necessary in the unhandled promise rejection handler.

@schlawg schlawg requested a review from kraktus October 31, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraktus kraktus Awaiting requested review from kraktus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schlawg