Make LibXML::Item use :config for boxing #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any config supplied by upstream was previously ignored and class mapping was expected to be done by `LibXML::Node`. This resulted in limited abilities of user code in controlling how boxing is done. See libxml-raku#94. Note that `LibXML::Node` still does its own class mapping because this is the point of final decision and in many cases it is invoked directly.
|
Following #94 and this comment in particular. For caching to work properly, i.e. for a An alternative would be to modify class mapping on the global configuration object and pointing it into a some kind of proxy-class which would then re-dispatch the call to an appropriate class, but that adds an extra call to the call chain. |
dwarring
pushed a commit
that referenced
this pull request
Feb 27, 2023
Move the call to $.raw.set-flags to a TWEAK submethod as it needs to be called after $.raw.Reference has been called. Any config supplied by upstream was previously ignored and class mapping was expected to be done by `LibXML::Node`. This resulted in limited abilities of user code in controlling how boxing is done. See #94. Note that `LibXML::Node` still does its own class mapping because this is the point of final decision and in many cases it is invoked directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any config supplied by upstream was previously ignored and class mapping was expected to be done by
LibXML::Node. This resulted in limited abilities of user code in controlling how boxing is done. See #94.Note that
LibXML::Nodestill does its own class mapping because this is the point of final decision and in many cases it is invoked directly.