Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/defer avatar #856

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature/defer avatar #856

wants to merge 3 commits into from

Conversation

klngwll
Copy link
Contributor

@klngwll klngwll commented Mar 16, 2023

No description provided.

niklasl
niklasl reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently hasAvatar is only set to false if it fails to load it. We need to set it to false, or remove this logic altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasl niklasl niklasl left review comments

@lrosenstrom lrosenstrom Awaiting requested review from lrosenstrom

@olovy olovy Awaiting requested review from olovy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klngwll @niklasl