Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/update pull request template #1067

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Chore/update pull request template #1067

wants to merge 3 commits into from

Conversation

johanbissemattsson
Copy link
Contributor

@johanbissemattsson johanbissemattsson commented Jun 12, 2024 •
edited
Loading

Checklist:

  • I have added tests for new features.
  • I have updated the changelog.

Description

Tickets involved

LWS-NNNN, LWS-NNNN

Solves

Updates the pull request template to better suite the workflow when developing Libris search.

Summary of changes

  • Instead of asking if we have run the tests we now ask if we have added tests for new features (as tests now run automatically on pushes and PRs using GitHub Actions).
  • Add reminder to update the changelog (we should preferably use something similar to changesets for this).

jesperengstrom
jesperengstrom approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@jesperengstrom jesperengstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the others are ok with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesperengstrom jesperengstrom jesperengstrom approved these changes

@lrosenstrom lrosenstrom Awaiting requested review from lrosenstrom

@olovy olovy Awaiting requested review from olovy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanbissemattsson @jesperengstrom