Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate script immediately (with explicit exit code) on error #1324

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Terminate script immediately (with explicit exit code) on error #1324

merged 2 commits into from
Nov 8, 2023

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Nov 8, 2023

  • Before, if a script contained several calls to select and one failed, the subsequent ones would still be run.
  • The exit code is useful e.g. for controlling the course of events when running Whelktool scripts from within a shell script.

andersju
andersju reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@andersju andersju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, otherwise LGTM!

whelktool/src/main/groovy/datatool/WhelkTool.groovy Outdated Show resolved Hide resolved
@kwahlin @andersju
Use proper exit code
f42d44f 
Co-authored-by: Anders Jensen-Urstad <[email protected]>
@kwahlin kwahlin merged commit 4935836 into develop Nov 8, 2023
1 check passed
@olovy olovy deleted the feature/whelktool-exit-on-error branch November 8, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersju andersju andersju approved these changes

@jannistsiroyannis jannistsiroyannis Awaiting requested review from jannistsiroyannis

@lrosenstrom lrosenstrom Awaiting requested review from lrosenstrom

@olovy olovy Awaiting requested review from olovy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwahlin @andersju