Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fmt 18 illustrators to instance #1298

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Aug 31, 2023

Updated criteria for when to keep illustrators on work according to https://jira.kb.se/browse/FMT-18. Let's try this and evaluate after next QA iteration.

Also the criteria for keeping illustrator on work don't necessarily
need to be met when instance type is Electronic. In that case it's
sufficient if any of the works in the cluster meet the criteria.
- 9pu and StillImage no longer sufficient criteria
- Always do the same action (move or keep) for the same illustrator within a cluster
- Clean up
Copy link
Contributor

@klngwll klngwll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Same thought regarding specific/reusable, but it's pretty clear that this is not an either/or, so let's just keep it in mind for "Works part II".)

@kwahlin kwahlin merged commit 34931e8 into develop Sep 7, 2023
1 check passed
@kwahlin kwahlin deleted the feature/fmt-18-illustrators-to-instance branch November 9, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants