Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/merge works clean #1288

Closed
wants to merge 270 commits into from
Closed

Feature/merge works clean #1288

wants to merge 270 commits into from

Conversation

kwahlin
Copy link
Contributor

@kwahlin kwahlin commented Aug 18, 2023

  • All the "work code" has been moved a separate module librisworks
  • A special tool (WorkTool) is no longer needed, instead the regular WhelkTool is used for document loading, saving, iterating etc., hence each step in the clustring/merging process is just a groovy script that runs with WhelkTool.
  • Those scripts are wrapped in run.sh, which takes as arguments the environment to run against and (optionally) flags to pass on to WhelkTool.
    Example: ./run.sh qa --dry-run
    I have run this locally to make sure that the functionality is maintained, i.e. getting the same result as when running from the old branch https://github.com/libris/librisxl/tree/feature/merge-works. Obviously we still need automatic tests as well.
  • All files that are not actively used at this point have been excluded. They can still be found in the old branch should we need to pick up some of it again.

@kwahlin kwahlin requested review from niklasl and olovy August 18, 2023 09:58
Copy link
Contributor

@olovy olovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Let's merge this and take it from there.

🚢

@kwahlin
Copy link
Contributor Author

kwahlin commented Aug 21, 2023

Replaced by #1290

@kwahlin kwahlin closed this Aug 21, 2023
@kwahlin kwahlin deleted the feature/merge-works-clean branch August 21, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants