Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intellij autocomplete etc inside whelktool scripts #1286

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

olovy
Copy link
Contributor

@olovy olovy commented Aug 17, 2023

This makes intellij recognize whelktool and whelk-core classes in whelktool scripts.
It does not make the "scripts" directory part of whelktool.jar.
Stuff made available to the scripts through javax.script.Bindings like selectBySqlWhere is not recognized.

After importing the gradle project a manual step has to be performed for it to work 100%. Se comment.

@olovy olovy force-pushed the feature/script-autocomplete branch from a346311 to 7493d25 Compare August 17, 2023 14:48
Copy link
Contributor

@kwahlin kwahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@olovy olovy merged commit dac3242 into develop Aug 17, 2023
1 check passed
@olovy olovy deleted the feature/script-autocomplete branch August 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants