Use .localhost instead of .kblocalhost.kb.se #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using kblocalhost.kb.se and id.kblocalhost.kb.se as domains for local development is an (increasingly) bad idea because in modern browsers an increasing number of features are only available in secure contexts -- essentially https://, http://127.0.0.1, http://localhost and http://*.localhost.
Among restricted features is, for example, the Web Crypto API, so we have a workaround for local development.
Let's just switch to .localhost. (Later on we might also want to use local self-signed certificates.)
To "migrate" from an old setup:
id.kblocalhost.kb.se
=>id.kb.se.localhost
andkblocalhost.kb.se
=>libris.kb.se.localhost
in the following files:/etc/hosts
librisxl/secret.properties
lxlviewer/nuxt-app/.env
lxlviewer/vue-client/.env.development
/etc/apache2/sites-enabled/something.conf
(or equivalent)fab xl_local app.whelk.import_work_example_data
lxlviewer/vue-client/.end.development
, changeVUE_APP_CLIENT_ID
(see chat or ask for new one)