add check also "dispserv_null" for "current_display_server" in video_display_server_destroy() #18557
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…display_server_destroy()
ShigeakiAsai
force-pushed
the
add-check-also-dispserv_null-for-current_display_server-in-video_display_server_destroy
branch
from
651d4e1 to
fc6cf8f
Compare
Author
|
I'm sorry I used old version code. I did update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Lakka RPi4.aarch64 using vulkan driver, retroarch takes Segmentation fault when 2nd times start cores after 1st time core is closed via retroarch menu.
In this case, retroarch video_display_server_destroy () calls current_display_server->destroy() function that is NULL pointer.
It needs to check not only "current_display_server( != NULL)" but also "current_display_server != &dispserv_null".
please refer libretro/Lakka-LibreELEC#2154
gl driver is not occured this issue.
Related Issues
libretro/Lakka-LibreELEC#2154
Related Pull Requests
Nothing now. I will create same modification patch to Lakka if it accepted, later.
Reviewers
I asked @gouchi ( and @zoltanvb ) about this issue via discord lakka channel.
Note.
This is my 1st Pull request. if this have any problem, please let me know.
Thanks
ASAI, Shigeaki