Cargo replace hex with faster-hex #1227
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, long time listener, first time caller...
I'm doing some work on the
spotify_id
module for another project including replacing the bespoke hex encode/decode there with a library call and I started usinghex
because it is a dependency of bothlibrespot
andlibrespot-core
already... buthex
doesn't appear to be maintained and it lacks really obvious stuff like symmetry between its traits and its functions and major performance issues (that we admittedly don't really care about here, yet).Anyway, looking around
crates.io
, I came acrossfaster-hex
which is still far from perfect but the maintainers seem active and likely responsive. So I patchedlibrespot
andlibrespot-core
to use it instead.Unfortunately, I couldn't work out how to test the hashcash challenge. I tried changing my
OS
but that either crashes (for"android"
) or fails with 400 (for"ios"
). I included the improved logging I added to try to understand these issues.If you could review the changes and let me know how to test the hashcash challenge (or test it yourself or confirm that LGTY), I would be grateful. I will be sending along my
spotify_id
refactoring changeset soon.Thanks!