hddtemp2: check if disk is a valid device and fix model name for smartctl #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
First one to check if disk is a valid device. In one case I have,
smartctl -i /dev/zd336
fails and returns:We should check if smartctl succeeds.
And last one strips spaces for model name returned otherwise the poller fails to parse hddtemp from unix_agent module:
For example it currently returns:
But should be:
cc @jasoncheng7115