-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Python implementation of cobyla #37
Draft
nbelakovski
wants to merge
6
commits into
libprima:main
Choose a base branch
from
nbelakovski:nbelakovski/python
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Sep 20, 2023
-
Initial commit of Python translation
calcfc_chebyqud and calcfc_hexagon in Python return values close to what is returned by Fortran, but not exactly the same and the difference is outside of machine precision. For chebyquad the fortran version iterates 387 times within cobylb, whereas the Python version iterates 564 times. The results are as follows Fortran: x(1) = 0.06687201625695266 x(2) = 0.28872054433564054 x(3) = 0.36668681233017669 x(4) = 0.63330363432938008 x(5) = 0.71126615229302259 x(6) = 0.93312277720964698 f = 3.9135366518694255e-10 Python: x[0] = 0.06688196439284098 x[1] = 0.2887610493288529 x[2] = 0.36668226015206873 x[3] = 0.6333320849097046 x[4] = 0.7112583722245663 x[5] = 0.9331254078707577 f = 3.8259601181730434e-10 The first position in x differs by 9.948135888e-6, so it's further away than machine precision, but it's possible that the difference is the result of accumulation of machine precision errors.
Configuration menu - View commit details
-
Copy full SHA for 8e536e1 - Browse repository at this point
Copy the full SHA 8e536e1View commit details
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40f7da9 - Browse repository at this point
Copy the full SHA 40f7da9View commit details
Commits on Sep 26, 2023
-
Added a readme with some style guidelines.
Implemented savehist and modified the return values to be more usable. I've gone through cobyla.py and it seems pretty close to the original. Remaining work is to implement retmsg and to add in all pre/post conditions and retrofit existing pre/post conditions to match the style guide. Then we're ready for a deeper conversation on whether any of this is useful XD
Configuration menu - View commit details
-
Copy full SHA for b233dfa - Browse repository at this point
Copy the full SHA b233dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b6108a - Browse repository at this point
Copy the full SHA 0b6108aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52d5647 - Browse repository at this point
Copy the full SHA 52d5647View commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1095cc1 - Browse repository at this point
Copy the full SHA 1095cc1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.