Refactor prima_is_success to accept options.ctol #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #195
I made it so that ctol is initialized to the default value that was being used. Another option is to check if options.ctol is NaN within
prima_is_success
, but I know we've discussed before thatisnan
can have issues with certain optimization levels.I'll think about it some more, but I'm not sure what other options there are. With either option above we need to maintain a default value within
prima.c
which is not ideal since that implies two places where default values are stored (prima.c
andconsts.f90
). Would it make sense to have aconsts
folder at the root of the repo, which then contains folders likefortran
,c
,python
, each of which defines const values for each of the languages, so that there's one place where these values are maintained?