Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should prima_get_rc_string be exposed in the C public API? #188

Open
zaikunzhang opened this issue Apr 9, 2024 · 1 comment
Open

Should prima_get_rc_string be exposed in the C public API? #188

zaikunzhang opened this issue Apr 9, 2024 · 1 comment
Assignees
Labels
c Issues related to the C interface or implementation

Comments

@zaikunzhang
Copy link
Member

Hi @nbelakovski ,

Why do we need prima_get_rc_string in the C public API? Shouldn't it be hidden from the users? We expect the users to get the string from result.message, no?

// Function to get the message string corresponding to a return code
PRIMAC_API
const char *prima_get_rc_string(const prima_rc_t rc);

Thank you for taking a look.

Best regards,
Zaikun

@zaikunzhang zaikunzhang added the c Issues related to the C interface or implementation label Apr 9, 2024
zaikunzhang added a commit that referenced this issue May 1, 2024
…` and `prima_init_result` static; the first handles #188
@jschueller
Copy link
Collaborator

jschueller commented Sep 4, 2024

I think the point was to hide the implementation of the result struct which could be an opaque struct at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Issues related to the C interface or implementation
Projects
None yet
Development

No branches or pull requests

3 participants