Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoringSSL #252

Merged
merged 4 commits into from
Jun 18, 2024
Merged

BoringSSL #252

merged 4 commits into from
Jun 18, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Jun 14, 2024

  • add BoringSSL (required for lsquic)
  • remove OpenSSL (replaced by BoringSSL)
  • add libsecp256k1 (secp256k1 not supported by BoringSSL)

}
return key;
return secp256k1_ecdsa_verify(ctx_.get(), &ffi_sig, digest.data(), &ffi_pub)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfectly fine and no need to change. Personally, I prefer splitting the line to assign a value of function to a temp variable for making easier possible debugging:

Suggested change
return secp256k1_ecdsa_verify(ctx_.get(), &ffi_sig, digest.data(), &ffi_pub)
auto verify_res = secp256k1_ecdsa_verify(ctx_.get(), &ffi_sig, digest.data(), &ffi_pub);
return verify_res == 1;

@turuslan turuslan merged commit 1e68917 into master Jun 18, 2024
4 checks passed
@turuslan turuslan deleted the boringssl branch June 18, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants