Renamed histEqual to histEqualize. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9il
reviewed
Nov 12, 2016
| Copy of input image slice with its histogram values equalized. | ||
| */ | ||
| deprecated("Use dcv.imgproc.filter.histEqualize") | ||
| Slice!(N, T*) histEqual(T, HistogramType, size_t N)(Slice!(N, T*) slice, HistogramType histogram, |
There was a problem hiding this comment.
Wanted to do this, but how to inform the deprecation? Is it possible to deprecate alias?
There was a problem hiding this comment.
Awesome! Will do..
|
LGTM |
|
See also dcv/tests/performance-tests/source/performance/measure.d |
ah, tnx.. |
I forgot about this one in bilateralFilter sigma separation PR, so I smuggled it here. Hope you don't mind. (it was failing to compile the benchmark app) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #76
I left histEqual with deprecation message. Will leave the issue until 0.2.0 version comes, and until we remove the histEqual.
@9il seems ok?