Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package metadata version retrieval fix. #392

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

guillermodotn
Copy link
Contributor

The package relies on setuptools to retrieve the package metadata version. However, this dependency is not included in pyproject.toml, leading to runtime errors, as described in issue #390.

Following the recommendation in the version.py module, the package will omit pkg_resources.get_distribution and instead utilize the built-in importlib.metadata.version method to retrieve the package version for Python version 3.8 and above.

For older Python versions (< 3.8), setuptools will be installed as a dependency.

@guillermodotn
Copy link
Contributor Author

Fixes: #390

@Evidlo Evidlo merged commit 4ae60b4 into libkeepass:master Jun 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants