Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add database name and description property #389

Merged
merged 2 commits into from
May 17, 2024
Merged

Add database name and description property #389

merged 2 commits into from
May 17, 2024

Conversation

janbrummer
Copy link
Contributor

No description provided.

@janbrummer
Copy link
Contributor Author

@Evidlo Could you please review this one?

@janbrummer
Copy link
Contributor Author

https://gitlab.gnome.org/World/secrets/-/merge_requests/878

@janbrummer
Copy link
Contributor Author

@A6GibKm Time for a review?

A6GibKm
A6GibKm reviewed Apr 20, 2024
View reviewed changes
Copy link
Contributor

@A6GibKm A6GibKm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please add a test for the setters and getters.

  • get value
  • set value to X
  • get value and check that it matches X
  • save db
  • close db
  • open db
  • check the it is still X

pykeepass/pykeepass.py Show resolved Hide resolved
pykeepass/pykeepass.py Outdated Show resolved Hide resolved
pykeepass/pykeepass.py Show resolved Hide resolved
@A6GibKm
Copy link
Contributor

A6GibKm commented Apr 20, 2024

Is this missing a rebase? I think python 3.6 tests were removed one or two weeks ago.

@janbrummer janbrummer force-pushed the database-info branch 3 times, most recently from def91e7 to 3aadce5 Compare April 23, 2024 07:25
@janbrummer
Copy link
Contributor Author

Thanks. Please add a test for the setters and getters.

* get value

* set value to X

* get value and check that it matches X

* save db

* close db

* open db

* check the it is still X

Added tests

@janbrummer
Add further database properties
5bd15ed 
Add database name, database description and default user name property.
@janbrummer
Copy link
Contributor Author

@Evidlo Can you please merge it?

@Evidlo Evidlo merged commit ad8b110 into libkeepass:master May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A6GibKm A6GibKm A6GibKm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janbrummer @A6GibKm @Evidlo