Introduce and use vmlinux crate #739
Merged
+218
−288,400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change converts all examples over to using the vmlinux crate for access to the vmlinux.h header file. Signed-off-by: Daniel Müller <deso@posteo.net>
Remove the examples/vmlinux/ folder and all the vendored vmlinux.h header files, now that they are no longer used. Signed-off-by: Daniel Müller <deso@posteo.net>
This change migrates the integration tests over to using the vmlinux crate for their vmlinux.h needs. It then also removes the one remaining vendored vmlinux.h copy from the repository. Signed-off-by: Daniel Müller <deso@posteo.net>
anakryiko
approved these changes
Mar 21, 2024
| use std::path::Path; | ||
| use std::path::PathBuf; | ||
|
|
||
| // TODO: Ideally we'd deduplicate contents at this level (as well; not just on |
There was a problem hiding this comment.
those are also huge text files which would compress very nicely, but I assume it's impossible in const context?
There was a problem hiding this comment.
Likely not in a const context, yeah. We could probably have a function based interface if need be and load and cache stuff on demand. I mostly got nerd-sniped here and wanted to make it work as I had originally envisioned...
The other avenue would to exclude unnecessary headers based on features. Either way, it's probably not urgent unless/until we use this functionality in anything but example & test code.
Not immediately, but if we decide to publish this crate eventually then yes, happy to adjust the code there. |
Bump the minimum supported Rust version to 1.71. This version will be required with subsequent changes, as it provides a const version of ptr::read(). Signed-off-by: Daniel Müller <deso@posteo.net>
Our handling of the vmlinux.h header file is super painful. That has
many reasons, including, but not limited to:
- nothing feels self-contained, as everything is relying on some
abstruse C header file somewhere
- we kind of sort of wanted to avoid shipping it so far and so every
component started vendoring their own copy
- that makes maintenance a nightmare
- some components do so taking the current target architecture into
account, others not; limiting possible compilation targets
- because unit tests are part of the containing library, which *is*
shipped, we are basically prevented from granting unit tests access
to vmlinux.h
- just finding the right path to the file is cumbersome and the logic
for doing so gets replicated all over the place
This change introduces a crate that tries to solve most (all?) of these
problems. It vendors vmlinux.h for various architectures and provides
file system as well as Rust-level access to contents. It also takes care
of honoring the current target architecture in doing so.
Long term we probably should consider publishing it, which would enable
usage from other repositories such as libbpf-bootstrap. We'd likely need
to version it in accordance with the kernel version that the headers
correspond to. For now, it's just a workspace member and will only be
used as dev-dependency.
Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.