Implement Sync for Link #1044
Merged
Implement Sync for Link #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Sync for Link. The only operations that can be performed on a &Link are pin_path() and detach(), neither of which modify the object. pin_path() just reads an attribute and detach() performs a system call with the link's file descriptor. Hence, Sync should be fine to implement for Link. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
pushed a commit
that referenced
this pull request
Dec 19, 2024
Pull request #1044 wrongfully added the new CHANGELOG item to the section for the already released 0.25.0-beta.1. Fix that. Signed-off-by: Daniel Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Sync for Link. The only operations that can be performed on a &Link are pin_path() and detach(), neither of which modify the object. pin_path() just reads an attribute and detach() performs a system call with the link's file descriptor. Hence, Sync should be fine to implement for Link.