Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "'retroactive' attribute does not apply here" error when using Xcode 16 RC #115

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

liamnichols
Copy link
Owner

image

@liamnichols liamnichols self-assigned this Sep 16, 2024
@liamnichols liamnichols changed the title Fix 'retroactive attribute does not apply here' error when using Xcode 16 RC Fix "'retroactive' attribute does not apply here" error when using Xcode 16 RC Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

✅ Pull Request passed benchmark checks

Summary

Mon Sep 16 10:31:16 UTC 2024

===========================================================================================================
Threshold deviations for StringGenerator.generateSource(for:tableName:accessLevel:):XCStringsToolBenchmarks
===========================================================================================================
Time (total CPU) (ms, %) main pull_request Difference % Threshold %
p25 357 304 -14 5
p50 357 304 -14 5
p75 359 306 -14 5

New baseline 'pull_request' is BETTER than the 'main' baseline thresholds.


Comparing results between 'main' and 'pull_request'

Host 'Mac-1726481009307.local' with 3 'arm64' processors with 7 GB memory, running:
Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:03 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_VMAPPLE

XCStringsToolBenchmarks

StringGenerator.generateSource(for:tableName:accessLevel:) metrics

Time (total CPU): results within specified thresholds, fold down for details.

Time (total CPU) (ms) * p0 p25 p50 p75 p90 p99 p100 Samples
main 356 357 357 359 359 359 359 3
pull_request 304 304 304 306 307 307 307 4
Δ -52 -53 -53 -53 -52 -52 -52 1
Improvement % 15 15 15 15 14 14 14 1

@liamnichols liamnichols merged commit bae89cb into main Sep 16, 2024
13 checks passed
@liamnichols liamnichols deleted the ln/retroactive-rc branch September 16, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant