Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Remove deprecated LocalizedStringResource API #107

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

liamnichols
Copy link
Owner

@liamnichols liamnichols commented Jul 19, 2024

Since 0.4.0, the LocalizedStringResource.XXX struct is now deprecated and instead the String.XXX struct should be used.

To prepare for 1.0.0, and some other upcoming changes, i'm now removing this deprecated code.

@liamnichols liamnichols self-assigned this Jul 19, 2024
Copy link

✅ Pull Request passed benchmark checks

Summary

Fri Jul 19 15:50:37 UTC 2024

===========================================================================================================
Threshold deviations for StringGenerator.generateSource(for:tableName:accessLevel:):XCStringsToolBenchmarks
===========================================================================================================
Time (total CPU) (ms, %) main pull_request Difference % Threshold %
p25 704 384 -45 5
p50 704 395 -43 5
p75 707 398 -43 5

New baseline 'pull_request' is BETTER than the 'main' baseline thresholds.


Comparing results between 'main' and 'pull_request'

Host 'Mac-1721402931035.local' with 3 'arm64' processors with 7 GB memory, running:
Darwin Kernel Version 23.5.0: Wed May  1 20:12:39 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_VMAPPLE

XCStringsToolBenchmarks

StringGenerator.generateSource(for:tableName:accessLevel:) metrics

Time (total CPU): results within specified thresholds, fold down for details.

Time (total CPU) (ms) * p0 p25 p50 p75 p90 p99 p100 Samples
main 703 704 704 707 707 707 707 2
pull_request 383 384 395 398 398 398 398 3
Δ -320 -320 -309 -309 -309 -309 -309 1
Improvement % 46 45 44 44 44 44 44 1

@liamnichols liamnichols marked this pull request as ready for review July 19, 2024 15:55
@liamnichols
Copy link
Owner Author

almost 2x speed improvement 😬

@liamnichols liamnichols merged commit 1e29ded into main Jul 19, 2024
13 checks passed
@liamnichols liamnichols deleted the ln/remove-deprecated-api branch July 23, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant