Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should allow specifying
plugin
among others inConstraint.create()
.See #817.
Sadly I do have basically two questions. First, running
npm install
and thennpm run test
gave me errors about missingpoly-decomp
so I added that. Is that a missing dependency? The demos seemed to run fine without it.Second: I tried to add in a dummy
extend
call, like this:This leads to a stack overflow, as the options (maybe
bodyA
orbodyB
?) seem to be recursive. UsingCommon.extend(defaults, false, options);
works, but I'm not sure what the ultimate consequences of that would be. I presume not different from the currentvar constraint = options;
so I've gone ahead and used that, but I still wanted to ask your opinion on that as it's different than Body's use of extend().