This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Maintenance listener throwing deprecation exception on PHP 7.4 in dev environment #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… environment - fixed the maintenance listener to handle case when request route is not set - updated unit test - added new versions of PHP (7.3 and 7.4) to the test list
leofeyer
reviewed
Jul 3, 2020
| @@ -194,7 +194,10 @@ public function onKernelRequest(GetResponseEvent $event) | |||
| } | |||
|
|
|||
| $route = $request->get('_route'); | |||
| if (null !== $this->route && preg_match('{'.$this->route.'}', $route) || (true === $this->debug && '_' === $route[0])) { | |||
| if ($route && ( | |||
There was a problem hiding this comment.
I don't think that this is correct, is it? See #95.
There was a problem hiding this comment.
it is covered by test and this approach is used in our project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation type:
Trying to access array offset on value of type null.Steps to reproduce:
s RouteListener (must be empty_route` in the Request)error_reportingin thephp.iniAdditional info: https://wiki.php.net/rfc/notice-for-non-valid-array-container