-
Notifications
You must be signed in to change notification settings - Fork 5
Type definition for node-modern-rcon. #2
base: master
Are you sure you want to change the base?
Conversation
Basic external type declaration that currently reflects `rcon.js`.
Just a thought, I'm not sure if you need to be exporting the I welcome you to review my main fork as well. There's some adjustments including logging and send can be immediately queued. Event handling is refined to be properly stateful. The state property is more informative. But fundamentally, the code you wrote is solid. Thanks again. I'm able to connect to Factorio successfully using Nodejs. :) I wonder how easy this would be to port to the browser. :| |
It's exported so people can check via |
Oh yeah of course. Something I blanked on. :P |
@levrik Ok all set. I added the last touch to the project file so it includes the typings and updated the patch version so it can be published. |
@@ -0,0 +1,23 @@ | |||
/// <reference types="node" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't these reference comments removed from TypeScript?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know they still work. Might be deprecated.
It depends on your module structure.
Basic external type declaration that currently reflects
rcon.js
.@levrik: thank you, and you're welcome. 😁