fix: Hyprland clash when unplug monitor

[AbaoFromCUG]

Fix

• Hyprland crash when unplugging monitor #68

Notice

• I would like to add CMakeLists.txt (proposal only)

[levnikmyskin]

Hi! Thank you very much for your contribution. Please, check whether this issue has already been solved on the dev branch. That's where we keep development for "rolling" hyprland (i.e., hyprland git). If not, feel free to rebase this pr so that it merges into dev rather than main :)

[AbaoFromCUG]

Hi! Thank you very much for your contribution. Please, check whether this issue has already been solved on the dev branch. That's where we keep development for "rolling" hyprland (i.e., hyprland git). If not, feel free to rebase this pr so that it merges into dev rather than main :)

I use the hyprland v0.45.2, which is release version from https://archlinux.org/packages/extra/x86_64/hyprland/
I can't build hyprland v0.45.2 with dev branch virtual-desktops, because API is incompatible:

src/main.cpp: In function ‘std::string printStateDispatch(eHyprCtlOutputFormat, std::string)’:
src/main.cpp:189:43: error: ‘class CWorkspace’ has no member named ‘getWindows’
  189 |                     windows += workspace->getWindows();
      |                                           ^~~~~~~~~~
src/main.cpp:199:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::unordered_map<int, std::shared_ptr<VirtualDesk> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  199 |             if (index++ < manager->vdesksMap.size() - 1)
      |                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/main.cpp:212:43: error: ‘class CWorkspace’ has no member named ‘getWindows’
  212 |                     windows += workspace->getWindows();
      |                                           ^~~~~~~~~~
src/main.cpp:229:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::unordered_map<int, std::shared_ptr<VirtualDesk> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  229 |             if (index++ < manager->vdesksMap.size() - 1)
      |                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/main.cpp: In function ‘std::string printLayoutDispatch(eHyprCtlOutputFormat, std::string)’:
src/main.cpp:260:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::unordered_map<const Hyprutils::Memory::CSharedPointer<CMonitor>, long int>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  260 |             if (++index < layout.size())
      |                 ~~~~~~~~^~~~~~~~~~~~~~~
src/VirtualDesk.cpp: In static member function ‘static Hyprutils::Memory::CSharedPointer<CMonitor> VirtualDesk::firstAvailableMonitor(const std::vector<Hyprutils::Memory::CSharedPointer<CMonitor> >&)’:
src/VirtualDesk.cpp:127:40: error: ‘class CWorkspace’ has no member named ‘getWindows’
  127 |             auto n_on_mon = workspace->getWindows();
      |                                        ^~~~~~~~~~
src/VirtualDesk.cpp: In member function ‘Layout VirtualDesk::generateCurrentMonitorLayout()’:
src/VirtualDesk.cpp:181:41: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
  181 |     for (int i = vdeskFirstWorkspace; i < vdeskFirstWorkspace + monitors.size(); i++) {
      |                                       ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:17: virtual-desktops.so] Error 1

I want to fix the issue occurring in hyprland v0.45.2, I can confirm that it also happened in hyprland-git. Because we will release CMonitor twice times.

[levnikmyskin]

I see. The code for this has already been changed in the dev branch though. The problem about not using hooks was that the virtual desks would get completely messed up when you connected/disconnected monitors. I added a few events to Hyprland, and this is now possible (even though several problems are still there).
Thank you for the cmake stuff though!

[AbaoFromCUG]

I understand. I will temporarily use the version I compiled myself, waiting for the release of hyprland.

Thank you for your patient explanation。

[levnikmyskin]

Thank you for your understanding, I'm sorry we couldn't use your work for this time, I do appreciate your contribution. And I think we're still crashing on dev, so might be related to something else. Feel free to look into it, once it's merged to main :)