Listen to new pre/post monitor connection/disconnection events #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
|
Thanks :) |
WhySoBad
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
The changes look good to me.
However, a thing I noticed which is not directly related to this pull request is that we should have a github action which lints the code (mainly for formatting). I think you use clang-format and I don't use a formatter which causes a lot of formatting changes as soon as you touch code which I added/modified.
|
yeah I totally agree @WhySoBad! I'm using clang-format with the same rules of the Hyprland codebase. Would you like to take care of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally removes the need to have the function hooks for monitor connection/disconnection. This is already merged into Hyprland hyprwm/Hyprland#8503
This should remove a good set of issues