fix: handle inexistent workspaces

levnikmyskin · Nov 25, 2024 · 525670f · 525670f
1 parent 8486445
commit 525670f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/VirtualDesk.cpp b/src/VirtualDesk.cpp
@@ -1,4 +1,5 @@
 #include "VirtualDesk.hpp"
+#include "src/Compositor.hpp"
 #include <numeric>
 #include <algorithm>
 #include <unordered_set>
@@ -121,10 +122,13 @@ CSharedPointer<CMonitor> VirtualDesk::firstAvailableMonitor(const std::vector<CS
     int                      n = INT_MAX;
     CSharedPointer<CMonitor> newMonitor;
     for (const auto& mon : currentlyEnabledMonitors()) {
-        auto n_on_mon = g_pCompositor->getWorkspaceByID(mon->activeWorkspaceID())->getWindows();
-        if (n_on_mon < n) {
-            n          = n_on_mon;
-            newMonitor = mon;
+        auto workspace = g_pCompositor->getWorkspaceByID(mon->activeWorkspaceID());
+        if (workspace) {
+            auto n_on_mon = workspace->getWindows();
+            if (n_on_mon < n) {
+                n          = n_on_mon;
+                newMonitor = mon;
+            }
         }
     }
     return newMonitor;

diff --git a/src/main.cpp b/src/main.cpp
@@ -184,7 +184,10 @@ std::string printStateDispatch(eHyprCtlOutputFormat format, std::string arg) {
             std::string  workspaces;
             bool         first = true;
             for (auto const& [monitor, workspaceId] : desk->activeLayout(manager->conf)) {
-                windows += g_pCompositor->getWorkspaceByID(workspaceId)->getWindows();
+                auto workspace = g_pCompositor->getWorkspaceByID(workspaceId);
+                if (workspace) {
+                    windows += workspace->getWindows();
+                }
                 if (!first)
                     workspaces += ", ";
                 else
@@ -204,7 +207,10 @@ std::string printStateDispatch(eHyprCtlOutputFormat format, std::string arg) {
             std::string  workspaces;
             bool         first = true;
             for (auto const& [monitor, workspaceId] : desk->activeLayout(manager->conf)) {
-                windows += g_pCompositor->getWorkspaceByID(workspaceId)->getWindows();
+                auto workspace = g_pCompositor->getWorkspaceByID(workspaceId);
+                if (workspace) {
+                    windows += workspace->getWindows();
+                }
                 if (!first)
                     workspaces += ", ";
                 else