Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return results that are relevant to current locale #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hamishwillee
Copy link

Fixes #27

This fix ensures that if you're in a multi-lingual document your search shows only the terms in the current language. This is particularly important when not all pages are translated, as it ensures the untranslated English version doesn't show up multiple times.

All it does is pass in the current locale, then check whether the current page location starts with that locale. I have tested this for Chinese and English pages, which start with /zh/ and /en/ respectively. It works fine when you are in those pages BUT does not work if you switch from English to Chinese (say) because it is only initialised when the page is first loaded. Still, much better for me than the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search should be work on Internationalized sites
1 participant