Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up from_bitmap_bytes, and use less unsafe #1

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Speed up from_bitmap_bytes, and use less unsafe #1

merged 2 commits into from
Sep 12, 2024

Commits on Sep 7, 2024

  1. Speed up from_bitmap_bytes, and use less unsafe 

    * Directly create an array/bitmap store based on the count of bits
* Use u64 words to count bits and enumerate bits
* Store in little endian, then just fixup any touched words
* Only use unsafe to reinterpret a whole bitmap container as bytes, everything
  else is safe
* Allow adding bytes up to the last possible offset
    @Dr-Emann
    Dr-Emann committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    feb538c View commit details
    Browse the repository at this point in the history

  2. add special case for creating a full bitmap container 

    we can setting an initial value in that case
    @Dr-Emann
    Dr-Emann committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    ed8f0cb View commit details
    Browse the repository at this point in the history