Skip to content

Fix fullscreen notifications on multi-monitor setups#892

Open
johndbritton wants to merge 1 commit intoleits:masterfrom
johndbritton:fix-multi-monitor-fullscreen-notification
Open

Fix fullscreen notifications on multi-monitor setups#892
johndbritton wants to merge 1 commit intoleits:masterfrom
johndbritton:fix-multi-monitor-fullscreen-notification

Conversation

@johndbritton
Copy link

@johndbritton johndbritton commented Feb 11, 2026

On devices with multiple screens, there are issues with fullscreen notifications. This updates the behavior to show the fullscreen notification on the active space of the primary screen, rather than the active screen as determined by mouse focus.

Fixes #859
Related #856
Maybe related to #882, #865

Summary by CodeRabbit

  • Bug Fixes
    • Improved fullscreen notification window positioning to correctly display on the primary screen with proper dimensions and behavior.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 11, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

Walkthrough

This PR fixes a bug where fullscreen meeting notifications displayed incorrectly on external monitor setups. It replaces NSScreen.main reference with NSScreen.screens.first, adjusts the window's collection behavior to moveToActiveSpace only, and explicitly sets the window frame using computed screen bounds.

Changes

Cohort / File(s) Summary
Fullscreen Notification Window Handling
MeetingBar/App/AppDelegate.swift
Modified screen detection to use first available screen instead of main screen; simplified collection behavior to moveToActiveSpace; added explicit window frame setting to ensure proper positioning on multi-monitor setups.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Monitors left and right, vertical heights so tall,
No more cropped notifications blocking all,
With screens.first now guiding the way,
MeetingBar shines bright, come what may! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The code changes directly address issue #859 by replacing NSScreen.main with NSScreen.screens.first and adjusting window behavior to ensure notifications display correctly on the primary screen.
Out of Scope Changes check ✅ Passed All changes are narrowly focused on fixing the multi-monitor fullscreen notification issue; no unrelated modifications are present in the changeset.
Title check ✅ Passed The pull request title directly describes the main change: fixing fullscreen notifications on multi-monitor setups, which aligns with the primary objective of addressing display and usability issues on multi-screen configurations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@johndbritton johndbritton changed the title Display fullscreen notification on the active space of the primary sc… Fix fullscreen notifications on multi-monitor setups Feb 11, 2026
@dosubot dosubot bot added the bug Something isn't working label Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.42%. Comparing base (84e0a9f) to head (eeabf50).

Files with missing lines Patch % Lines
MeetingBar/App/AppDelegate.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #892       +/-   ##
===========================================
+ Coverage   26.30%   36.42%   +10.11%     
===========================================
  Files          36       48       +12     
  Lines        5645     5101      -544     
  Branches     2210     1733      -477     
===========================================
+ Hits         1485     1858      +373     
+ Misses       4103     3186      -917     
  Partials       57       57               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johndbritton
Copy link
Author

@leits are you open to contributions to this repository? Alternatively, do you consider bringing on other maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Fullscreen meeting notification breaks on external monitors

1 participant