Fix fullscreen notifications on multi-monitor setups#892
Fix fullscreen notifications on multi-monitor setups#892johndbritton wants to merge 1 commit intoleits:masterfrom
Conversation
WalkthroughThis PR fixes a bug where fullscreen meeting notifications displayed incorrectly on external monitor setups. It replaces NSScreen.main reference with NSScreen.screens.first, adjusts the window's collection behavior to moveToActiveSpace only, and explicitly sets the window frame using computed screen bounds. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
===========================================
+ Coverage 26.30% 36.42% +10.11%
===========================================
Files 36 48 +12
Lines 5645 5101 -544
Branches 2210 1733 -477
===========================================
+ Hits 1485 1858 +373
+ Misses 4103 3186 -917
Partials 57 57 ☔ View full report in Codecov by Sentry. |
|
@leits are you open to contributions to this repository? Alternatively, do you consider bringing on other maintainers? |
On devices with multiple screens, there are issues with fullscreen notifications. This updates the behavior to show the fullscreen notification on the active space of the primary screen, rather than the active screen as determined by mouse focus.
Fixes #859
Related #856
Maybe related to #882, #865
Summary by CodeRabbit