Skip to content

Translations update from Hosted Weblate#862

Open
weblate wants to merge 14 commits intoleits:masterfrom
weblate:weblate-meetingbar-app
Open

Translations update from Hosted Weblate#862
weblate wants to merge 14 commits intoleits:masterfrom
weblate:weblate-meetingbar-app

Conversation

@weblate
Copy link
Contributor

@weblate weblate commented Aug 20, 2025

Translations update from Hosted Weblate for MeetingBar/App.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • New Features

    • Added localized “Links” tab, status‑bar ongoing‑meeting visibility/timing options, a day‑timeline visual toggle, and a notification “Dismiss” action.
  • Bug Fixes / Improvements

    • Revised UI copy across Portuguese (pt‑BR), Spanish, German, Croatian, Polish and Dutch for clearer labels, prompts and notifications; adjusted status‑bar icon label wording.
  • Other

    • Added a Simplified Chinese localization placeholder (empty file).

Lucas-FcNw and others added 2 commits August 21, 2025 00:02
Currently translated at 35.1% (98 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/pt_BR/
Currently translated at 35.1% (98 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/pt_BR/
@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Updated and added localization string entries across multiple locale files (pt-BR, es, de, hr, pl, nl, added empty zh-Hans), making textual edits and introducing new preference/timeline/notification keys; changes are text-only localization updates.

Changes

Cohort / File(s) Summary
Portuguese (pt-BR)
MeetingBar/Resources/Localization/pt-BR.lproj/Localizable.strings
Multiple string edits (phrasing, punctuation) and added keys: preferences_tab_links, preferences_appearance_status_bar_ongoing_*, preferences_appearance_menu_show_timeline_toggle, notifications_meetingbar_dismiss_event_action.
Spanish (es)
MeetingBar/Resources/Localization/es.lproj/Localizable.strings
Updated preferences_appearance_status_bar_icon_app_icon_value (preserves NBSP).
German (de)
MeetingBar/Resources/Localization/de.lproj/Localizable.strings
Wording/punctuation tweaks, expanded shared_send_notification_no_alert_style_tip, and added preference/ongoing/timeline keys.
Croatian (hr)
MeetingBar/Resources/Localization/hr.lproj/Localizable.strings
Multiple wording/tense adjustments for events/notifications; added preference/ongoing/timeline keys and notifications_meetingbar_dismiss_event_action.
Polish (pl)
MeetingBar/Resources/Localization/pl.lproj/Localizable.strings
Updated browser-message and notification tip; added preferences_tab_links, preferences_appearance_status_bar_ongoing_*, and timeline visualization key.
Dutch (nl)
MeetingBar/Resources/Localization/nl.lproj/Localizable.strings
Minor change: general_ok value updated from "OK" to "Oke".
Simplified Chinese (zh-Hans)
MeetingBar/Resources/Localization/zh-Hans.lproj/Localizable.strings
New file added (currently empty).

Sequence Diagram(s)

(Skipped — changes are localization-only; no control-flow modifications.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • leits

Poem

I hop through strings with nimble paws,
Tweaking words and fixing flaws.
Links and timelines now in line,
Tiny edits — everything's fine. 🐇

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title "Translations update from Hosted Weblate" accurately describes the main changeset, which consists entirely of localization updates across multiple language files (Portuguese, Spanish, German, Croatian, Chinese, Polish, Dutch). The title is concise, clear, and conveys the primary change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 20, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (1)

49-49: Prefer “da área de transferência” for consistency with existing strings

Suggestion to align preposition with Line 193 (“Abrir reunião da área de transferência”) and common PT‑BR usage. Keeps the added “link” clarification intact.

-"preferences_general_shortcut_join_from_clipboard" = "Entrar na reunião pelo link na área de transferência:";
+"preferences_general_shortcut_join_from_clipboard" = "Entrar na reunião pelo link da área de transferência:";
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b82a797 and 1b8f402.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (1)
MeetingBar/UI/StatusBar/StatusBarItemController.swift (1)
  • setupKeyboardShortcuts (127-143)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan



"shared_fullscreen_notification_toggle" = "Exibir notificação em tela cheia";
"preferences_tab_links" = "Links";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

New tab label added — verify presence across locales and Base to avoid fallback

Translation “Links” looks correct and consistent with other tab titles. Please verify this key exists in Base.lproj and other localizations to prevent missing-string fallbacks at runtime. Also consider relocating this entry near the other “Preferences tabs” keys (Lines 33–37) for maintainability.


🏁 Script executed:

#!/bin/bash
# Verify the new key exists across localizations and Base
set -euo pipefail

echo "Searching for Localizable.strings files..."
fd -a Localizable.strings

echo -e "\nChecking occurrences of preferences_tab_links..."
rg -n "preferences_tab_links" -S -g "*Localizable.strings" -C1 || true

echo -e "\nExpected: At least one occurrence in Base.lproj and parity across *.lproj."

Length of output: 6613


Missing ‘preferences_tab_links’ in multiple locales and no Base.lproj

  • The repo does not include a Base.lproj directory—en.lproj serves as the base localization.
  • The new key is present in these Localizable.strings files:
    • en.lproj, pt-BR.lproj, uk.lproj, tr.lproj, ta.lproj, sk.lproj, nl.lproj, it.lproj, ko.lproj, es.lproj, fr.lproj, he.lproj
  • It is missing in the following locales (add it to prevent runtime fallbacks):
    • cs.lproj, de.lproj, enm.lproj, hr.lproj, hu.lproj, ja.lproj, nb-NO.lproj, pl.lproj, pt.lproj
  • After adding each translation, move the entry into the “Preferences tabs” block—immediately following preferences_tab_bookmarks and before preferences_tab_calendars—to keep all tab labels grouped together.

Currently translated at 53.7% (150 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/pt_BR/
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 24, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (1)

337-344: Grammar/style fixes for new strings + move ‘preferences_tab_links’ to the tabs block + unify “Dismiss” wording

  • Move “preferences_tab_links” into the “Preferences tabs” group (Lines 33–37) for maintainability and discoverability. This mirrors the structure in other locales.
  • Fix grammar:
    • “Ocultar e depois de iniciar” → “Ocultar ao iniciar”.
    • “Ocultar 10 min .. depois inicie” → “Ocultar 10 min após o início”.
    • “Mostre visualmente a linha do tempo do dia” → “Mostrar linha do tempo do dia” to match imperative style (“Mostrar …”) used across toggles.
  • Unify “Dismiss” as “Ignorar” to stay consistent with status bar items (“Ignorar reunião atual/próxima” at Lines 195, 197, 227).

Rephrase the affected keys:

-"preferences_appearance_status_bar_ongoing_time_immediate_value" = "Ocultar e depois de iniciar";
+"preferences_appearance_status_bar_ongoing_time_immediate_value" = "Ocultar ao iniciar";

-"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "Ocultar 10 min .. depois inicie";
+"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "Ocultar 10 min após o início";

-"preferences_appearance_menu_show_timeline_toggle" = "Mostre visualmente a linha do tempo do dia";
+"preferences_appearance_menu_show_timeline_toggle" = "Mostrar linha do tempo do dia";

-"notifications_meetingbar_dismiss_event_action" = "Dispensar";
+"notifications_meetingbar_dismiss_event_action" = "Ignorar";

Relocate the tab key:

- "preferences_tab_links" = "Links";

Insert it under “// MARK: - Preferences tabs” (after “preferences_tab_bookmarks” and before “preferences_tab_calendars”):

+ "preferences_tab_links" = "Links";

To double-check consistency across locales and ensure “Dispensar” isn’t used elsewhere unexpectedly, you can run:

#!/bin/bash
# Verify placement and wording across the repo
set -euo pipefail

echo "Occurrences of preferences_tab_links across Localizable.strings:"
rg -n -H --no-heading -S 'preferences_tab_links' -g '*Localizable.strings' -C1 || true

echo -e "\nOccurrences of 'Dispensar' vs 'Ignorar' in Localizable.strings:"
rg -n -H --no-heading -S 'Dispensar|Ignorar' -g '*Localizable.strings' -C1 || true
🧹 Nitpick comments (4)
MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (4)

49-49: Unify clipboard phrasing with the rest of the UI

Elsewhere we say “da área de transferência” (e.g., Line 193: “Abrir reunião da área de transferência”). Recommend aligning this label to avoid mixed phrasing.

-"preferences_general_shortcut_join_from_clipboard" = "Entrar na reunião pelo link na área de transferência:";
+"preferences_general_shortcut_join_from_clipboard" = "Entrar na reunião da área de transferência:";

129-131: Keep singular/plural consistent between alert title and message

The title is plural (“configurações”), but the message (Line 130) is singular (“a configuração”). Use singular in the title for consistency.

-"preferences_configure_browsers_delete_alert_title" = "Excluir configurações de navegador da web?";
+"preferences_configure_browsers_delete_alert_title" = "Excluir configuração de navegador da web?";

139-141: Panel title/prompt grammar polish

  • Prefer “navegador da web” for consistency with other strings here.
  • Use the imperative “Escolha um …” for the prompt rather than the infinitive.
-"preferences_configure_browsers_choose_browser_panel_title" = "Selecionar um aplicativo de navegador web";
+"preferences_configure_browsers_choose_browser_panel_title" = "Selecionar um aplicativo de navegador da web";
-"preferences_configure_browsers_choose_browser_panel_prompt" = "Escolher navegador da web";
+"preferences_configure_browsers_choose_browser_panel_prompt" = "Escolha um navegador da web";

169-169: Minor style tweak for natural pt-BR flow

“Apenas use…” is understandable, but “Use … apenas …” is more idiomatic.

-"preferences_advanced_setting_warning" = "⚠️ Apenas use essas configurações se você entender o que elas fazem";
+"preferences_advanced_setting_warning" = "⚠️ Use essas configurações apenas se você entender o que elas fazem";
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1b8f402 and 17df001.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (7 hunks)
🔇 Additional comments (1)
MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (1)

160-160: LGTM — improved naturalness

“Adicionar conta de calendário” reads more natural in pt-BR than “do calendário”. No issues.

"preferences_appearance_status_bar_title" = "Barra de status";
"preferences_appearance_status_bar_icon_title" = "Ícone";
"preferences_appearance_status_bar_icon_app_icon_value" = "\U00A0MeetingBar";
"preferences_appearance_status_bar_icon_app_icon_value" = " .BarraDeReunião";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix brand string and stray dot; do not localize “MeetingBar”

Brand names should remain untranslated. The current value has an extra dot and a localized brand (“BarraDeReunião”). Preserve the leading NBSP, but restore “MeetingBar”.

-"preferences_appearance_status_bar_icon_app_icon_value" = " .BarraDeReunião";
+"preferences_appearance_status_bar_icon_app_icon_value" = " MeetingBar";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"preferences_appearance_status_bar_icon_app_icon_value" = " .BarraDeReunião";
"preferences_appearance_status_bar_icon_app_icon_value" = " MeetingBar";
🤖 Prompt for AI Agents
In MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings around
line 87, the value for preferences_appearance_status_bar_icon_app_icon_value
wrongly localizes the brand and contains a stray dot; replace the translated
“BarraDeReunião” and the extra dot with the original brand name while preserving
the leading non‑breaking space, i.e. set the value to the NBSP followed by
"MeetingBar".

Currently translated at 100.0% (279 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/es/
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1)

336-341: Fix Spanish grammar/accents for ongoing/timeline strings

Minor language fixes for clarity and consistency with earlier “mostrar/ocultar” usage.

-"preferences_appearance_status_bar_ongoing_title" = "Visibilidad el evento actual:";
-"preferences_appearance_status_bar_ongoing_time_immediate_value" = "Esconder despues de empezar";
-"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "esconder 10 min después de empezar";
-"preferences_appearance_status_bar_ongoing_time_ten_before_next_value" = "esconder 10 min antes del próximo evento";
-"preferences_appearance_menu_show_timeline_toggle" = "Mostrar la linea de tiempo del dia";
+"preferences_appearance_status_bar_ongoing_title" = "Visibilidad del evento actual:";
+"preferences_appearance_status_bar_ongoing_time_immediate_value" = "Ocultar después de empezar";
+"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "Ocultar 10 min después de empezar";
+"preferences_appearance_status_bar_ongoing_time_ten_before_next_value" = "Ocultar 10 min antes del próximo evento";
+"preferences_appearance_menu_show_timeline_toggle" = "Mostrar la línea de tiempo del día";
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 17df001 and 7b86bd7.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1)
MeetingBar/UI/Views/Preferences/AppearanceTab.swift (1)
  • StatusBarSection (144-256)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan

"preferences_appearance_status_bar_title" = "Barra de estado";
"preferences_appearance_status_bar_icon_title" = "Icono";
"preferences_appearance_status_bar_icon_app_icon_value" = "\U00A0MeetingBar";
"preferences_appearance_status_bar_icon_app_icon_value" = " Bar de reuniones";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Keep brand name “MeetingBar” and normalize NBSP encoding

This label refers to the app icon; brand names shouldn’t be localized. Also, use the explicit NBSP escape to stay consistent with neighboring keys.

-"preferences_appearance_status_bar_icon_app_icon_value" = " Bar de reuniones";
+"preferences_appearance_status_bar_icon_app_icon_value" = "\U00A0MeetingBar";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"preferences_appearance_status_bar_icon_app_icon_value" = " Bar de reuniones";
"preferences_appearance_status_bar_icon_app_icon_value" = "\U00A0MeetingBar";
🤖 Prompt for AI Agents
In MeetingBar/Resources /Localization /es.lproj/Localizable.strings around line
86, the value localizes the brand name and uses a literal NBSP; update the value
to keep the brand name untranslated and normalize the non‑breaking space
encoding by replacing the current string with one that uses the explicit escape
and the brand: "\u00A0MeetingBar".

Currently translated at 96.0% (268 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/de/
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /de.lproj/Localizable.strings (1)

329-329: Relocate key to the Preferences tabs section

Move this entry next to other preferences_tab_* keys (around Lines 115–119) to keep grouping consistent and reduce merge noise.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b86bd7 and 6024f1a.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /de.lproj/Localizable.strings (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
MeetingBar/Resources /Localization /de.lproj/Localizable.strings (1)
MeetingBar/UI/Views/Preferences/LinksTab.swift (3)
  • LinksTab (12-193)
  • CreateMeetingServicePicker (195-214)
  • AddBookmarkModal (216-291)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan
🔇 Additional comments (2)
MeetingBar/Resources /Localization /de.lproj/Localizable.strings (2)

329-329: Good addition: new tab key present

The German label for the new Links tab is added and reads naturally in-context.


329-329: Verified — key present across locales and used in code.
All .lproj/Localizable.strings define preferences_tab_links and it's referenced at MeetingBar/UI/Views/Preferences/Preferences.swift:17.

Currently translated at 100.0% (279 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/de/
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 26, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6024f1a and 1010352.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /de.lproj/Localizable.strings (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan

Comment on lines +150 to 151
"status_bar_submenu_undismiss_meeting" = "Verwerfen entfernen";
"status_bar_submenu_email_attendees" = "E-Mail an Teilnehmer";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Rephrase “undismiss” action

“Verwerfen entfernen” sounds awkward and doesn’t communicate the action. “Verwerfen rückgängig machen” keeps the intent (undo a dismissal) clear for users.

-"status_bar_submenu_undismiss_meeting" = "Verwerfen entfernen";
+"status_bar_submenu_undismiss_meeting" = "Verwerfen rückgängig machen";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"status_bar_submenu_undismiss_meeting" = "Verwerfen entfernen";
"status_bar_submenu_email_attendees" = "E-Mail an Teilnehmer";
"status_bar_submenu_undismiss_meeting" = "Verwerfen rückgängig machen";
"status_bar_submenu_email_attendees" = "E-Mail an Teilnehmer";
🤖 Prompt for AI Agents
In MeetingBar/Resources /Localization /de.lproj/Localizable.strings around lines
150 to 151, the German translation "Verwerfen entfernen" for the key
status_bar_submenu_undismiss_meeting reads awkwardly; replace it with "Verwerfen
rückgängig machen" so the action clearly indicates undoing a dismissal while
leaving the surrounding entries unchanged.

Comment on lines +312 to 313
"shared_send_notification_no_alert_style_tip" = "Hinweis: Benachrichtigungen sind als Banner eingestellt, deshalb erscheinen sie kurzzeitig, bevor sie wieder verschwinden. Damit die Benachrichtigungen bis zum Verwerfen sichtbar bleiben, müssen sie als Alarme in den macOS-Benachrichtungseinstellungen eingestellt werden.";
"welcome_screen_shortcut_next_meeting_title" = "Am nächsten Meeting mit Tastaturkürzel teilnehmen:";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fix typo in notification hint

There’s a typo in “macOS-Benachrichtungseinstellungen”; it should read “macOS-Benachrichtigungseinstellungen.” Please correct it to avoid shipping a misspelled UI string.

-"shared_send_notification_no_alert_style_tip" = "Hinweis: Benachrichtigungen sind als Banner eingestellt, deshalb erscheinen sie kurzzeitig, bevor sie wieder verschwinden. Damit die Benachrichtigungen bis zum Verwerfen sichtbar bleiben, müssen sie als Alarme in den macOS-Benachrichtungseinstellungen eingestellt werden.";
+"shared_send_notification_no_alert_style_tip" = "Hinweis: Benachrichtigungen sind als Banner eingestellt, deshalb erscheinen sie kurzzeitig, bevor sie wieder verschwinden. Damit die Benachrichtigungen bis zum Verwerfen sichtbar bleiben, müssen sie als Alarme in den macOS-Benachrichtigungseinstellungen eingestellt werden.";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"shared_send_notification_no_alert_style_tip" = "Hinweis: Benachrichtigungen sind als Banner eingestellt, deshalb erscheinen sie kurzzeitig, bevor sie wieder verschwinden. Damit die Benachrichtigungen bis zum Verwerfen sichtbar bleiben, müssen sie als Alarme in den macOS-Benachrichtungseinstellungen eingestellt werden.";
"welcome_screen_shortcut_next_meeting_title" = "Am nächsten Meeting mit Tastaturkürzel teilnehmen:";
"shared_send_notification_no_alert_style_tip" = "Hinweis: Benachrichtigungen sind als Banner eingestellt, deshalb erscheinen sie kurzzeitig, bevor sie wieder verschwinden. Damit die Benachrichtigungen bis zum Verwerfen sichtbar bleiben, müssen sie als Alarme in den macOS-Benachrichtigungseinstellungen eingestellt werden.";
"welcome_screen_shortcut_next_meeting_title" = "Am nächsten Meeting mit Tastaturkürzel teilnehmen:";
🤖 Prompt for AI Agents
In MeetingBar/Resources /Localization /de.lproj/Localizable.strings around lines
312-313, the German string contains a typo: "macOS-Benachrichtungseinstellungen"
should be "macOS-Benachrichtigungseinstellungen"; update the value for the key
"shared_send_notification_no_alert_style_tip" to use the corrected word and save
the file so the localized UI string is spelled correctly.

milotype and others added 2 commits October 5, 2025 15:02
Currently translated at 100.0% (279 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/hr/
Copy link

@mskopp mskopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the german translations

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)

323-324: Remove duplicate key with incorrect language.

Line 323 contains Japanese text (%@ を開くアプリ) in the Polish localization file, and line 324 redefines the same key with the correct Polish translation. This duplicate key definition will cause the first value to be overwritten.

🐛 Proposed fix

Remove line 323 (the Japanese text entry):

-"preferences_services_link_service_title" = "%@ を開くアプリ";
 "preferences_services_link_service_title" = "Otwórz linki do %@ w";
🤖 Fix all issues with AI agents
In @MeetingBar/Resources /Localization /pl.lproj/Localizable.strings:
- Line 341: The translation string for key
"preferences_appearance_status_bar_ongoing_time_ten_after_value" contains a
double space between "min" and "po"; update the value to use a single space so
it reads "ukryj 10 min po rozpoczęciu".
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ca9cae and 08942d3.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /pl.lproj/Localizable.strings
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan
🔇 Additional comments (1)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)

337-340: New localization keys look good.

The new Polish translations for preferences links, status bar ongoing event visibility, and timeline visualization are properly formatted and follow the established naming conventions.

Also applies to: 342-342

"preferences_appearance_status_bar_ongoing_title" = "Widoczność trwającego wydarzenia:";
"preferences_appearance_status_bar_ongoing_time_immediate_value" = "ukryj po rozpoczęciu";
"preferences_appearance_menu_show_timeline_toggle" = "Pokaż wizualizację osi czasu dnia";
"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix double space in translation.

There's an extra space between "min" and "po" in the translation text.

✨ Proposed fix
-"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min  po rozpoczęciu";
+"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
🤖 Prompt for AI Agents
In @MeetingBar/Resources /Localization /pl.lproj/Localizable.strings at line
341, The translation string for key
"preferences_appearance_status_bar_ongoing_time_ten_after_value" contains a
double space between "min" and "po"; update the value to use a single space so
it reads "ukryj 10 min po rozpoczęciu".

Currently translated at 99.2% (277 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/pl/
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)

317-342: Fix duplicate localization keys and typo in Polish strings file.

  • preferences_services_link_service_title is defined twice (lines 323 and 324). Line 323 contains Japanese text (%@ を開くアプリ) in a Polish file, which is unintended. Keep only the correct Polish entry on line 324.
  • status_bar_section_refresh_sources appears twice (lines 189 and 335) with identical values. Remove the duplicate on line 335 to avoid silent overrides.
  • preferences_appearance_status_bar_ongoing_time_ten_after_value has an extra space on line 341: "10 min po" should be "10 min po".
Proposed fix
-"preferences_services_link_service_title" = "%@ を開くアプリ";
 "preferences_services_link_service_title" = "Otwórz linki do %@ w";
@@
-"status_bar_section_refresh_sources" = "Odśwież źródła";
@@
-"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min  po rozpoczęciu";
+"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08942d3 and 85f35df.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /pl.lproj/Localizable.strings
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan
🔇 Additional comments (2)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (2)

136-137: Wording update looks good / clearer.
No issues with this change.


274-275: Long tip string: OK, but double-check UI truncation/wrapping.
The text is valid for .strings; just ensure the UI control that displays it supports long, multi-sentence content without truncation.

Currently translated at 100.0% (279 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/pl/
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)

321-335: Duplicate keys / mixed-language entries risk overriding Polish strings.

This file appears to define some keys multiple times (and at least one non-Polish value), e.g. duplicate preferences_services_link_service_title, status_bar_section_refresh_sources, status_bar_submenu_attendees_status_unknown. In .strings, duplicates can cause “last value wins” surprises and/or lint failures—worth de-duplicating (ideally in a separate cleanup PR if out of scope).

🤖 Fix all issues with AI agents
In @MeetingBar/Resources /Localization /pl.lproj/Localizable.strings:
- Around line 337-342: The localization string for
preferences_appearance_status_bar_ongoing_time_ten_after_value contains an extra
space ("10 min  po") that will appear in the UI; edit the value for
"preferences_appearance_status_bar_ongoing_time_ten_after_value" to remove the
double space so it reads "ukryj 10 min po rozpoczęciu" (ensure only a single
space between "min" and "po").
🧹 Nitpick comments (2)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (2)

136-136: Consider making the browser-panel message more specific to the action (app vs. “miejsce”).

Given the surrounding title/prompt already say “Wybierz przeglądarkę”, “miejsce uruchomienia” can read a bit ambiguous; if this is an app-picker panel, wording like “Wybierz aplikację przeglądarki internetowej” may be clearer.


257-257: Wording check: “(rekomendowane)” vs. more natural “(zalecane)”.

Not a blocker, but “zalecane” tends to be the more idiomatic UI phrasing in Polish.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85f35df and b7f7385.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /pl.lproj/Localizable.strings
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Security Scan
🔇 Additional comments (1)
MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)

274-274: LGTM: clearer macOS notification-style explanation.

This reads clearer than the prior warning-style text and explains the banner vs alert behavior directly.

Comment on lines +337 to +342
"preferences_tab_links" = "Linki";
"preferences_appearance_status_bar_ongoing_title" = "Widoczność trwającego wydarzenia:";
"preferences_appearance_status_bar_ongoing_time_immediate_value" = "ukryj po rozpoczęciu";
"preferences_appearance_menu_show_timeline_toggle" = "Pokaż wizualizację osi czasu dnia";
"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
"preferences_appearance_status_bar_ongoing_time_ten_before_next_value" = "ukryj do 10 min przed następnym wydarzeniem";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix extra whitespace in Line 341 (user-facing typo).

Line 341 has a double space ("10 min po"), which will show in UI.

Proposed fix
-"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min  po rozpoczęciu";
+"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"preferences_tab_links" = "Linki";
"preferences_appearance_status_bar_ongoing_title" = "Widoczność trwającego wydarzenia:";
"preferences_appearance_status_bar_ongoing_time_immediate_value" = "ukryj po rozpoczęciu";
"preferences_appearance_menu_show_timeline_toggle" = "Pokaż wizualizację osi czasu dnia";
"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
"preferences_appearance_status_bar_ongoing_time_ten_before_next_value" = "ukryj do 10 min przed następnym wydarzeniem";
"preferences_tab_links" = "Linki";
"preferences_appearance_status_bar_ongoing_title" = "Widoczność trwającego wydarzenia:";
"preferences_appearance_status_bar_ongoing_time_immediate_value" = "ukryj po rozpoczęciu";
"preferences_appearance_menu_show_timeline_toggle" = "Pokaż wizualizację osi czasu dnia";
"preferences_appearance_status_bar_ongoing_time_ten_after_value" = "ukryj 10 min po rozpoczęciu";
"preferences_appearance_status_bar_ongoing_time_ten_before_next_value" = "ukryj do 10 min przed następnym wydarzeniem";
🤖 Prompt for AI Agents
In @MeetingBar/Resources /Localization /pl.lproj/Localizable.strings around
lines 337 - 342, The localization string for
preferences_appearance_status_bar_ongoing_time_ten_after_value contains an extra
space ("10 min  po") that will appear in the UI; edit the value for
"preferences_appearance_status_bar_ongoing_time_ten_after_value" to remove the
double space so it reads "ukryj 10 min po rozpoczęciu" (ensure only a single
space between "min" and "po").

Currently translated at 100.0% (279 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/nl/
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@MeetingBar/Resources` /Localization /nl.lproj/Localizable.strings:
- Line 64: Update the Dutch localization entry for the general OK string: change
the value for the "general_ok" key from "Oke" to the standard Dutch spelling
"Oké" in the Localizable.strings resource so the app uses the accented form.

"preferences_services_link_default_browser_value" = "Standaard webbrowser";
"preferences_services_supported_links_list" = "Ondersteunde links voor diensten:\n%@";
"general_ok" = "OK";
"general_ok" = "Oke";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor: Standard Dutch spelling is "Oké" (with accent).

The standard Dutch spelling per Van Dale is "Oké" rather than "Oke". That said, both are widely understood, so this is a minor nit.

-"general_ok" = "Oke";
+"general_ok" = "Oké";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"general_ok" = "Oke";
"general_ok" = "Oké";
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@MeetingBar/Resources` /Localization /nl.lproj/Localizable.strings at line 64,
Update the Dutch localization entry for the general OK string: change the value
for the "general_ok" key from "Oke" to the standard Dutch spelling "Oké" in the
Localizable.strings resource so the app uses the accented form.

Currently translated at 3.5% (10 of 279 strings)

Translation: MeetingBar/App
Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/zh_Hans/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.