Feature/#17 회원 탈퇴 api #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| user_id: requestDto.userId, | ||
| is_deleted: false, | ||
| }, | ||
| data: { is_deleted: true, updated_at: new Date() }, |
There was a problem hiding this comment.
Suggested change
| data: { is_deleted: true, updated_at: new Date() }, | |
| data: { is_deleted: true }, |
updated_at 은 어차피 db에서 자동으로 업데이트 될때마다 넣어주기 때문에 업데이트를 안하셔도 될 것 같습니다.
model User {
user_id BigInt @id @default(autoincrement())
nickname String?
email String?
provider Provider?
is_deleted Boolean? @default(false)
created_at DateTime @default(now())
updated_at DateTime @updatedAt
subscriptions Subscription[]
tokens Token[]
notifications Notification[]
@@unique([provider, email])
@@map("user")
}| where: { | ||
| user_id: requestDto.userId, | ||
| }, | ||
| data: { refresh_token: '', updated_at: new Date() }, |
There was a problem hiding this comment.
Suggested change
| data: { refresh_token: '', updated_at: new Date() }, | |
| data: { refresh_token: '' }, |
위와 코멘트는 동일합니다 :)
There was a problem hiding this comment.
파일명을 signout.spec.ts -> signout.e2e-spec.ts로 바꾸셔야 할 것 같습니다.
지금하신건, 단위테스트가 아닌 통합테스트(or e2e)테스트로 보입니다!
테스트 코드도 지금 작성하신게 환경에 따라 결과가 다르게 나올 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
변경 사항
체크리스트
관련 이슈
리뷰 반영 사항
선택 항목 펼치기
스크린샷
테스트 방법
리뷰어 참고사항