Try reinitializing context if updateParametersInContext fails#309
Open
lilyminium wants to merge 3 commits intoleeping:masterfrom
Open
Try reinitializing context if updateParametersInContext fails#309lilyminium wants to merge 3 commits intoleeping:masterfrom
lilyminium wants to merge 3 commits intoleeping:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in OpenMM where trying to update a simulation without actually changing parameters triggers a pretty esoteric error. This arose for me during Iteration 0 of trying to reproduce a past TIP4P-FB fit, because update_simulation is called even though the FF has not been optimized yet.
Opening as a draft PR for now to see if existing tests trigger the error -- if not, I'll come up with my own test :-)
I ran a timing test and reinitializing the context is about an order of magnitude slower than updateParametersInContext -- reinitializing takes ~35 ms compared to 4.6 ms for updateParametersInContext. So I think the try/except is much more preferable than reinitializing every time.
Code below, and notebook PDF
time-reinitialization.pdf