Got rid of "wide" links in index.html#1060
Open
enderwiggum wants to merge 1 commit intoleeoniya:masterfrom
Open
Got rid of "wide" links in index.html#1060enderwiggum wants to merge 1 commit intoleeoniya:masterfrom
enderwiggum wants to merge 1 commit intoleeoniya:masterfrom
Conversation
The anchor tags on index.html page were styled to be block elements (display: block), that caused the entire width of the page around a given anchor to be clickable... which has repeatedly annoyed me when trying to look at the demos / learn uplot. Example: when focusing a browser window displaying the index.html by clicking in whitespace on the page, you accidentally trigger the link to whatever demo your pointer happens to be horizontally aligned with. I removed the display:block from the anchor tags, wrapped said anchors in <div>, and gave each div the class 'demo'. The page looks the same, but the links are now confined to the immediate space around the anchors.
Owner
|
hey, thanks :) instead of wrapping each link in a div, what do you think about wrapping all the links in a div like this: <div style="white-space: pre-line; line-height: 2em;">
...
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anchor tags on index.html page were styled to be block elements (display: block), that caused the entire width of the page around a given anchor to be clickable... which has repeatedly annoyed me when trying to look at the demos / learn uplot.
Example: when focusing a browser window displaying the index.html by clicking in whitespace on the page, you accidentally trigger the link to whatever demo your pointer happens to be horizontally aligned with.
I removed the display:block from the anchor tags, wrapped said anchors in